Problem/Motivation

Every major version update to core requires an update to zurb_foundation for any theme that uses it as a base theme. This complicates the development cycle and makes major upgrades more difficult.

Steps to reproduce

Use drush to generate a starter kit theme from baseline zurb_foundation. Wait till there is a new core major version upgrade. Deal with it.

Proposed resolution

It seems Drupal has moved on from the old system we used for sub-theming, change record. Not that sub-theming doesn't have it's place, rather that with the increased velocity, and the focus on backwards compatibility, I think it makes sense for Zurb Foundation to move to using Drupal's starterkit api.

Remaining tasks

Judging from the docs and cores starterkit theme, this shouldn't be too difficult of a task.

1. Remove the existing Sub-theme
2. Add a zurb_foundation.starterkit.yml file as per the change record.
3. Update the Drush Commands
4. Test

User interface changes

None

API changes

The Drush command to create a new sub-theme would now make a non-sub-theme.

Data model changes

Our starterkit would no longer be a sub-theme.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

frob created an issue. See original summary.

frob’s picture

Issue summary: View changes
frob’s picture

Status: Active » Needs review

Ready for review, test it with

php core/scripts/drupal generate-theme foozf --name "fooZF" --description "Custom theme from zf" --starterkit zurb_foundation

This will make a new theme from the zurb foundation theme.

frob changed the visibility of the branch 9.x to hidden.

frob’s picture

Think about this further. This should really be a new major version of the theme. Too much has had to change to accommodate the building of the starterkit.