The gitlab CI pipeline gives a series of warnings on the code in this module.

Let's review this and fix where necessary

Issue fork webform_analysis-3527223

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

batigolix opened merge request !16

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Active » Needs review
Issue tags: +finalist-sprint
ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Ignore my comment ~~ went through the file then understood the reason of typecasting the numeric value.

Changes looks to be mergeable as pipeline are clean ~~ marking this one RTBC

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented

  • batigolix committed 31f68234 on 8.x-1.x 
    Issue #3527223 by batigolix, ankitv18: Make code pass the gitlab...
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.