Problem/Motivation

Code quality is a bit disturbing.
Add gitlab-ci.yml to run phpcs and other checks.

Steps to reproduce

Proposed resolution

Add gitlab-ci.yml to run phpcs and other checks.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork paragraphs_browser-3527001

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jannakha created an issue. See original summary.

jannakha opened merge request !18

jannakha’s picture

jannakha commented
Status: Active » Needs review

MR18 ready for review

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

RTBC++

bvoynick made their first commit to this issue’s fork.

  • bvoynick committed ab47b728 on 8.x-1.x authored by jannakha 
    task: #3527001 Add Gitlab CI: phpcs, etc

By: jannakha
By: borisson_
By...
bvoynick’s picture

bvoynick
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Sounds good. These may fail for a while, as much as there is to work through, but let's at least start surfacing these things.

That said, I don't think we should count any currently failing things as hard fails - that would hold up other tasks until the pipelines were satisfied. I've set allowed_failure so that the state of the current codebase is considered "warning." Addressing these things in follow-ups would be great and allow_failure can be disabled down the road if we can get to a clean slate.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.