Problem/Motivation

There is some work here (https://www.drupal.org/project/linkit/issues/3388565) towards allowing the linkit module to default link text to entity titles instead of entity paths.

As outlined in this comment (https://www.drupal.org/project/linkit/issues/3388565#comment-15609354), it isn't compatible with editor_advanced_link.

Steps to reproduce

Using the linkit patch from #3388565 while also having editor_advanced_link enabled, the inserted link does not default to the entity title as desired.

Proposed resolution

The ckeditor plugins in linkit and editor_advanced_link have some duplicate code. See function _addExtraAttributeOnLinkCommandExecute, which is based on linkit's function _addExtraAttributesOnLinkCommandExecute.

Bring the editor_advanced_link ckeditor plugin in-line reflect the changes made to the above linkit function changes from #3388565

Issue fork editor_advanced_link-3526372

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drasgardian created an issue. See original summary.

drasgardian opened merge request !33

drasgardian closed merge request !33

drasgardian opened merge request !34

drasgardian’s picture

drasgardian commented
Related issues: +#3388565: Populate displayedText with entity title when left blank
robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
commented

I'm not quite sure what the issue is... I've noticed that if the CKE text format has both Linkit and the Editor Advanced Link filters enabled, when adding a link, the title attribute is not populated in the CKE/Linkit form, but is actually rendered in HTML (if Automatically set the title attribute to that of the (translated) referenced content is set in Text Format > Linkit URL converter). Is this the problem you're addressing here?

I cannot apply the MR as a patch file, and looks like the MR has failed