Problem/Motivation

I'm in the process of upgrading a site to use Quicktabs 4.0.1 this morning. When I downloaded the new version I noticed that it required a new dependency, drupal/js_cookie. I looked up why this change was made. After doing that research I expected that there would be subsequent database updates to enable this new dependency. Nope. There were no DB updates. And I wondered if things would be broken as a result.

Upon loading a page with Quicktabs I was greeted with the following errors:

User warning: The following theme is missing from the file system: js_cookie in Drupal\Core\Extension\ExtensionPathResolver->getPathname() (line 63 of core/lib/Drupal/Core/Extension/ExtensionPathResolver.php).

...and...

Deprecated function: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in Drupal\Core\Extension\ExtensionPathResolver->getPath() (line 85 of /app/drupal/phytochem/web/core/lib/Drupal/Core/Extension/ExtensionPathResolver.php)

Steps to reproduce

Upgrade a site with existing quicktabs from a 3.x version to a 4.x version. Load a page with those tabs in the output.

Proposed resolution

Add an update function to enable the js_cookie module.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork quicktabs-3526113

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam opened merge request !44

dcam’s picture

dcam commented
Status: Active » Needs review

PHPCS is complaining about an EoL character in the new quicktabs.install file. Unfortunately, I'm working in the web IDE today and can't do much about it. The committer may want to run PHPCBF on the MR before committing.

Also, I selected 8001 for the hook_update_N() because my site's schema number was set to 8000. I'm aware that there's no consensus on what numbering scheme everyone should use. Just replace it with whatever you think is appropriate.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.