When executing the commerceApplyCoupon mutation I get the following error:

For error #0: LogicException: Missing input mapper for argument orderType. in Drupal\graphql\Plugin\GraphQL\DataProducer\DataProducerProxy->prepare() (line 208 of /app/docroot/modules/contrib/graphql/src/Plugin/GraphQL/DataProducer/DataProducerProxy.php)

I will provide a fix in an MR.

Issue fork graphql_commerce-3525869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

milanbombschliip created an issue. See original summary.

milanbombschliip opened merge request !13

milanbombschliip opened merge request !14

milanbombschliip closed merge request !14

milanbombschliip opened merge request !15

milanbombschliip’s picture

milanbombschliip commented

Phpunit schema extension tests are failing. But they are also failing on 2.0.x if you only upgrade to PHP 8.3 https://git.drupalcode.org/issue/graphql_commerce-3525869/-/pipelines/50.... PHP 8.2 is not available in the Drupal pipeline anymore. All module functions (including the GetCart Graphql endpoint) are working if I include my code into my project.

milanbombschliip’s picture

milanbombschliip commented

Tests are fixed now. Needed to enable the 'default' bundles in the tests and change the addToCart endpoint to resolve the order inside the resolve() function to better handle nullable input.

milanbombschliip closed merge request !15

milanbombschliip’s picture

milanbombschliip commented
Status: Active » Needs review
czigor’s picture

czigor commented

Finally hopefully I have some time to review this properly.

On the one hand https://github.com/ddev/ddev-drupal-contrib/blob/main/README.md says

Commit the changes in the .ddev folder after this plugin installs. This saves other users from having to install this integration.

However, https://www.drupal.org/project/search_api/issues/3520659#comment-16149749 says

Hi, DDEV maintainer here. I don't usually encourage committing .ddev in contexts like this.

I also feel bad about committing it, so let's remove all ide and ddev related additions from the MR.

milanbombschliip’s picture

milanbombschliip commented

@czigor Agree. Should I do it or will you? Sorry for not making different issues for each of the improvements in this MR.

czigor’s picture

czigor commented

@milanbombschliip I've already started, thanks. And now the actual review part.

czigor opened merge request !16

  • czigor committed db52f165 on 2.0.x 
    Issue #3525869 by milanbombschliip, czigor: ApplyCoupon is broken
czigor’s picture

czigor commented
Status: Needs review » Fixed

Added some CS and test fixes as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pfrenssen made their first commit to this issue’s fork.