Problem/Motivation

margin-right is used, but that works fine in LTR languages, not RTL languages

Steps to reproduce

Switch site e.g. to Arabic

Proposed resolution

use 'margin-inline-end' instead of margin-right

Remaining tasks

MR, but haven't created one as this will have merge conflict with automated test coverage #3525066: Add automated test coverage

User interface changes

Compatibility with RTL

API changes

N/A

Data model changes

N/A

Comments

scott_euser created an issue. See original summary.

  • 0aa43ac4 committed on 1.0.x 
    Issue #3525406: Use logical properties for RTL compatibility
dahousecat’s picture

dahousecat commented

I did not know about the margin-inline-end css property so thanks - I will find that useful in a number of other projects I have going on.

However from my testing it was not creating the gap as required, as least with the rest of my theme present, so I have use grid-gap instead, as it will consistently place the margin between the 2 elements, regardless of text direction.

dahousecat’s picture

dahousecat commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.