Problem/Motivation

Contact module is being deprecated. Usages is tests not in Contact needs to removed and test coverage moved to the Contact module.

Steps to reproduce

Move jsonapi tests to the contact module.

Proposed resolution

Move tests from jsonapi to contact

  • core/modules/contact/tests/src/Functional/Jsonapi/ContactFormTest.php
  • core/modules/contact/tests/src/Functional/Jsonapi/MessageTest.php

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3525074

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !12154

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Title: Move test coverage to the contact module » Move jsonapi coverage to the contact module
Issue summary: View changes
Status: Active » Needs review

Changes this to just the jsonapi tests, which are the easy ones. Moving work on the others to another issue.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Seems straight forward

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Move jsonapi coverage to the contact module » Move JSON:API coverage for Contact to the Contact module

Clarifying title, since my kneejerk reaction was "wait that's backwards". 😀

  • xjm committed b0d5a9a8 on 11.x 
    Issue #3525074 by quietone: Move JSON:API coverage for Contact to the...

  • xjm committed 2ab02a9e on 11.2.x 
    Issue #3525074 by quietone: Move JSON:API coverage for Contact to the...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x, and backported to 11.2.x for parity since it changes only the test suite. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !12154