Problem/Motivation

No test coverage

Steps to reproduce

Check pipelines

Proposed resolution

Add test coverage

Remaining tasks

MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork entity_reference_field_autocomplete_filter-3525066

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !3

scott_euser’s picture

scott_euser commented
Status: Active » Postponed

This is going to fail as it needs these:

  1. #3525065: Widget allows scope to expand beyond restrictions
  2. #3525063: Widget missing schema

But then still needs work once those are resolved to add a few more autocomplete attempts and prove the restricted results.

dahousecat’s picture

dahousecat commented

This is next on the to-do list but I'll need to complete this task in my own time so will have to wait for now.

scott_euser’s picture

scott_euser commented

Just to note it's mostly there in the MR. I would be happy to complete it

dahousecat’s picture

dahousecat commented

Thanks again Scott, I totally missed that.

If your happy to complete that then i would be very grateful.

I'm a bit new to MRs on drupal.org - if you could give me any pointers on how to merge then that would be super helpful!

scott_euser’s picture

scott_euser commented
Status: Postponed » Active

Sure absolutely, I posted here in one of the issues you merged with details: https://www.drupal.org/project/entity_reference_field_autocomplete_filte...

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs review

Tests now passing. Note that in the MR is a slight change to #3525063: Widget missing schema as the schema was still throwing a validation error (test coverage automatically triggers config validation)

dahousecat’s picture

dahousecat commented
Status: Needs review » Reviewed & tested by the community
dahousecat’s picture

dahousecat commented
Status: Reviewed & tested by the community » Fixed

Thanks Scott - runs fine locally.

Really appreciate you adding this test.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.