Problem/Motivation

Fatal error: Declaration of Drupal\ai_vdb_provider_sqlite\Plugin\VdbProvider\SQLiteProvider::vectorSearch(string $collection_name, array $vector_input, array $output_fields, string $filters = '', int $limit = 10, int $offset = 0, ?string $database = null): array must be compatible with Drupal\ai\AiVdbProviderInterface::vectorSearch(string $collection_name, array $vector_input, array $output_fields, Drupal\search_api\Query\QueryInterface $query, string $filters = '', int $limit = 10, int $offset = 0, string $database = 'default'): array in /var/www/html/web/modules/contrib/ai_vdb_provider_sqlite/src/Plugin/VdbProvider/SQLiteProvider.php on line 287

the 1.1.x version introduced a breaking change in this function signature in #3486166: AI Search: Pass metric type to vector search function (which is technically ok because it is still experimental..)

Steps to reproduce

update the ai modules to their 1.1.x branches.

Proposed resolution

I don't know.. maybe branching 1.1.x as well?
Or maybe just drop support for 1.0.x and go for >1.1 of the ai module like ai_vdb_provider_postgres does
I would also appreciate a dev release for the raw branches so that they show up in the version selection on issues :D

Remaining tasks

review patch.
Maybe we can do the same as pgvector now with this?

User interface changes

none

API changes

none?

Data model changes

none

Issue fork ai_vdb_provider_sqlite-3524631

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bircher created an issue. See original summary.

bircher opened merge request !1

jimyhuang made their first commit to this issue’s fork.

jimyhuang’s picture

jimyhuang commented
Version: 1.0.0-beta2 » 1.0.0

I have released version 1.0.0, and I've configured the Composer dependency to use the stable version of the AI module.
Next, I merged your pull request into the 1.0.0 branch, create the 1.1.x branch, and then release version 1.1.x-dev which stick 1.1.x version of AI module.

jimyhuang’s picture

jimyhuang commented
Version: 1.0.0 » 1.1.x-dev
Status: Active » Needs review

Released 1.1.x-dev.
https://www.drupal.org/project/ai_vdb_provider_sqlite/releases/1.1.x-dev

jimyhuang’s picture

jimyhuang commented
Status: Needs review » Fixed

Seems fixed.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.