Auto-save data should update itself when the Fallback plugin is (de)activated

This would be a massive change in the auto-save architecture.

Unfortunately, the ADR for that still hasn't landed: #3512616: Document the reasons for not using Workspaces for saving in XB 1.0.0. 😬

@tedbow, thoughts? :D

Wow, very cool to see that:

• this uses the infrastructure that #3519634: Modifying a XB config entity's `status` or `label` should update the auto-save entry too, rather than delete it added
• this basically does what I suggested over at #3515629-16: FieldWidget's XB transforms must be bubbled by the Field Widget rendering to inform the client.2, where I sketched how I think this could actually happen automatically.

Very cool!

With all of the other changes that have landed in the last few weeks, is this issue still relevant? If so, what are the steps to create a broken auto-save state?

Tagging as a beta blocker to answer this question and evaluate. Depending on the answer, we might decide that actually fixing it doesn't necessarily have to block a beta.

Great call, @effulgentsia!

+1 to @larowlan's analysis in #11 + #12.

Test-only CI job fails 👍}

Clarifying the issue scope per #4 and what's in the MR.

I'm wondering if \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\FallbackInputTest::testFallbackInputCanBeRecovered() is not essentially obsolete thanks to \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\ComponentSourceTestBase::testFallback() since recent changes wrt when the Fallback plugin becomes active (#3523841: Versioned Component config entities (SDC, JS: prop_field_definitions, block: default_setting, all: slots for fallback) + component instances refer to versions ⇒ less data to store per XB field row, #3528723: Component::onDependencyRemoval() should be an uninstall validator if the dependency being removed is a module or theme etc.).

In that ::testFallback() test coverage I also spotted

    if (static::class === BlockComponentTest::class) {
      // @todo Update Component entities with BlockComponent source plugin: https://drupal.org/i/3484682
      $this->markTestIncomplete('Block components do not yet update component config entities');
    }

… but #3484682: Handle update and delete of Block `Component`s, plus react to dependency removal landed a while ago. We forgot this bit. We can remove it with zero changes AFAICT.

AFAICT:

1. \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\FallbackInputTest::testFallbackInputCanBeRecovered() is now pretty much a duplicate of \Drupal\Tests\experience_builder\Kernel\Plugin\ExperienceBuilder\ComponentSource\SingleDirectoryComponentTest::getPropsForComponentFallbackTesting() — down to the same alt that is being asserted!
2. We only need to move assertions such as self::assertCount(1, $crawler->filter('img[alt="An image so amazing that to gaze upon it would melt your face"]')); into a new abstract method that each ComponentSourceTestBase should implement, because then we could call that method after this assertion at the end of ::testFallback()
   

       // Should be no fallback container.
       self::assertCount(0, $out->filter('[data-fallback]'));
       foreach ($slots as $slot) {
         // Children should still render in the slots.
         self::assertCount(1, $out->filter(\sprintf('h1:contains("This is %s")', $slot)));
       }
   

   👆 that tests after fallback recovery the A) absence of the fallback container, B) the presence of the slots, so adding C) presence of rendered props to that would make it complete.

I belive that this would benefit the overall maintainability.

👍 Thanks!

#3529622: Make auto-save manager only support passing and returning entity objects, remove support for arbitrary data, use deterministic hashing to ensure entries are actually updates is in!

No longer applies due to #3529622: Make auto-save manager only support passing and returning entity objects, remove support for arbitrary data, use deterministic hashing to ensure entries are actually updates :)

Rerolling

merged 0.x but tests will fail because it still needs for the new way we store auto-save data

🥳