Overview

In the Shoe Icon Library, the two dropdown fields – Color and Size – the second option (the one immediately after "None") is not visible(see attached screenshot).
The first option ("None") appears as expected, but the value right below it is missing from both dropdowns.
size_dropdown
color_dropdown
Steps to Reproduce:

  1. Navigate to the Shoe Icon Library interface.
  2. Check the Color dropdown from the settings, the second select value is not visible, but can be selected.
  3. Check the Size dropdown, the second select value is not visible, but can be selected.

While resolving the issue, we need to take care that default value didn't got changed.

Proposed resolution

User interface changes

CommentFileSizeAuthor
color_dropdown.png36.85 KBjatingupta40
ADSASD.png46.61 KBjatingupta40

Issue fork experience_builder-3523860

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jatingupta40 created an issue. See original summary.

jatingupta40’s picture

jatingupta40 commented
Issue summary: View changes

jatingupta40 opened merge request !1027

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: User interface » Shape matching
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Thanks for jumping on this, @jatingupta40!

This is technically correct, because it's what the component defined. Fixing it in our components won't prevent other components from outside of XB to do that.

In #3516602: SDC `enum` props should have human-readable labels: use `meta:enum` (and potentially in core #3493070: SDC `enum` props should have translatable labels: use `meta:enum`) we will allow to provide labels for every enum value, including those enum values that are the empty string.

We still need to figure out if there's any technical reason for not allowing an empty value, which I'm not sure it does exist anymore.
If it does, we would need to update SingleDirectoryComponent::checkRequirements() to detect and disallow components that provide those.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3503087: Disallow SDCs with `type: string, enum: …` with an empty string listed to convey optionality: the prop should then just be optional

I think this is a duplicate of #3503087: Disallow SDCs with `type: string, enum: …` with an empty string listed to convey optionality: the prop should then just be optional.

jatingupta40’s picture

jatingupta40 commented
Status: Active » Closed (duplicate)

Thanks @penyaskito for clarifying this so well.
Closing this ticket as it is a duplicate of - https://www.drupal.org/project/experience_builder/issues/3503087

jatingupta40’s picture

jatingupta40 commented