Problem/Motivation

When "Date format for exception day" is set to anything other than "Default long date" it is displayed like this: 05America/New_York090000000005

Steps to reproduce

Set "Date format for exception day" to anything else

Proposed resolution

My guess is that it's not finding the format string correctly.

Also, when the exception date doesn't have any times (it's closed on that day), it shows still shows a time as midnight "Friday, May 9, 2025 - 12:00am"

Comments

troybthompson created an issue. See original summary.

  • johnv committed 16d4220c on 8.x-1.x 
    Issue #3523693 by troybthompson: Date format for exception day not...
johnv’s picture

johnv
Primary language Dutch
commented
Component: Code » Code - formatter
Status: Active » Fixed

Indeed. Above patch should do the trick.

  • johnv committed ee2f287e on 8.x-1.x 
    Issue #3523693 by troybthompson: Date format for exceptions formatter -...
troybthompson’s picture

troybthompson commented

This solved the problem, thank you! It still shows midnight (even if there are hours for the exception) but if the format chosen doesn't show time, it's ok. Maybe a different issue.

johnv’s picture

johnv
Primary language Dutch
commented

Nice.
" It still shows midnight (even if there are hours for the exception) " Can you share a screenprint of this?

johnv’s picture

johnv
Primary language Dutch
commented

The second commit was needed because both 'short' and 'long' are valid options for 'time'/'weekday' and 'date'.
And Exceptions need both:
- weekday on widget,
- date on formatter.
So I needed to break this apart, and move the 'weekday' to Slot.php, since that class is bey definition in the widget, and the value is used per slot, not per day, as in the formatter.

  • johnv committed e9bb9a02 on 8.x-1.x 
    Issue #3523693: Fix spelling  errors

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.