Problem/Motivation

If a user searches for a term and accidentally adds a space (" ") at the end of the search term, instead of trimming the search term and looking it up, an error appears:

Invalid URI: A URI must not start nor end with ASCII control characters or spaces.

Steps to reproduce

  1. Create a search page.
  2. Go to that search page.
  3. Search the term "test ".
  4. See the error appearing.

Proposed resolution

Trime searched terms.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search_api_page-3523613

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

grevil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

I can confirm this. Input should definitely always be trimmed for this reason. As it causes a hard exception, I'd say this is high prio.

grevil opened merge request !13

grevil’s picture

grevil commented
Status: Active » Needs review

Done, please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Simple, but effective fix! :) Thanks!

danheisel’s picture

danheisel commented

Thanks for this fix. It has solved most of my team's search errors from users but it left the error when directly accessing a search result URL. Lately, a site my team maintains has been hit with crawlers attempting to access search results using seemingly valid queries that are appropriate for the site content. While we sort through which crawlers are valid, we are getting quite a few pages in the logs that still fail with this error. The crawlers are accessing the result pages directly with URLs like, "/search/test%20". The error does not appear on the search page if the query string is used instead of the clean URL. The only fix for the clean URL option that we found for this was to trim the keys on PathProcessorSearchApiPage in the ProcessInbound function. This also seems to clean it up for the form and results.

karlshea made their first commit to this issue’s fork.

  • karlshea committed 5b57788f on 8.x-1.x authored by grevil 
    feat: #3523613 Searched terms are not trimmed

By: grevil
By: anybody
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.