Problem/Motivation

according to upgrade status there are 9 issues.

CommentFileSizeAuthor
#11 3521717-add-d11-support-11.patch13.08 KBbmunslow
#9 3521717-add-d11-support-9.patch7.97 KBjelle_s
#8 3521717-add-d11-support-8.patch7.2 KBjelle_s
#6 3521717-add-d11-support-6.patch6.04 KBjonasanne
#4 3521717-add-d11-support-4.patch5.69 KBjonasanne

Issue fork rng-3521717

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonasanne created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented

If you want to make a start on this, that would be great! It will take a while until the site that I use RNG on is ready for Drupal 11, so that's why I gave porting this module to D11 a low priority.

jonasanne opened merge request !21

jonasanne’s picture

jonasanne commented
Status: Active » Needs review
StatusFileSize
new 3521717-add-d11-support-4.patch5.69 KB

I created a MR with the necessary changes.
Upgrade status still flags 1 deprecation but for D12 so we are safe in D11.
Added diff of MR to use as patch.

megachriz’s picture

megachriz
Primary language Dutch
commented

I see that RNG has no gitlab CI support enabled yet. Do you want to add that, perhaps in an other issue, and then fix any test failures that may occur?

jonasanne’s picture

jonasanne commented
StatusFileSize
new 3521717-add-d11-support-6.patch6.04 KB

jelle_s made their first commit to this issue’s fork.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new 3521717-add-d11-support-8.patch7.2 KB

New patch for those that want to use it in composer.patches.json

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new 3521717-add-d11-support-9.patch7.97 KB

bmunslow made their first commit to this issue’s fork.

bmunslow’s picture

bmunslow commented
StatusFileSize
new 3521717-add-d11-support-11.patch13.08 KB
megachriz’s picture

megachriz
Primary language Dutch
commented

Finally my client has given me time to get this ready for Drupal 11. It looks like most of the changes posted here have been resolved by getting #3521729: Add gitlab CI support done first.

Patch in #11 will no longer apply, but my hope is that I can get D11 support in quickly now. I aim before the end of this month.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Needs work

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Fixed

Yay! Tests on Drupal 11 pass, so I merged the code. Applying patches from this issue ticket is no longer necessary.

I have not manually tested the module yet on Drupal 11, so it is possible some issues arise. I plan to test this module on the site that is in the process of being upgraded to Drupal 11, hopefully in the next few weeks.

While working on getting this module to work on Drupal 11, I noticed some of the dependencies of RNG are abandoned or appear to be abandoned. Dependency Courier is officially abandoned. Dependency Unlimited Number Field appears to be abandoned. Because of that, my client is considering to move away from RNG in the future. When that happens, I will abandon RNG too and this project becomes unsupported as well.

I will try if I could get the module compatible with Drupal 12 now, but only if it takes minimal effort. I'll first try to resolve the remaining PHPStan issues in a follow-up.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • megachriz committed 1c5573c3 on 3.0.x authored by jonasanne 
    task: #3521717 Added D11 support.

By: megachriz
By: jonasanne
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.