Problem/Motivation

Screenshot showing alert with link having insufficient contrast ratio

Steps to reproduce

  1. Create an alert (of any type) containing a link in the Message field and publish
  2. (optional) set the link's style to one of the secondary button styles
  3. Observe the alert

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 secondary_button_contrast.png16.84 KBjdleonard
alert_contrast_ratio.png60.39 KBjdleonard

Comments

jdleonard created an issue. See original summary.

fionamorrison23’s picture

fionamorrison23 commented
Version: 1.10.0 » 1.x-dev
Assigned: Unassigned » fionamorrison23
Issue tags: +civictheme-release-1.12
fionamorrison23’s picture

fionamorrison23 commented

Hi @jdleonard,
Thanks for reporting this. However, the screenshot you've provided doesn't show the button style as per the steps to reproduce. When the link is styled as a button it is accessible, but when not styled as a button, it displays as per your screenshots, which are clearly inaccessible.
I've created a ticket for our designer to update Figma to include a link, we'll then get this fixed.
However, this issue should be in GitHub in the UIKit rather than Drupal. I'm closing this ticket and instead we will work from https://github.com/civictheme/uikit/issues/548

fionamorrison23’s picture

fionamorrison23 commented
fionamorrison23’s picture

fionamorrison23 commented
Status: Active » Closed (duplicate)
Issue tags: -civictheme-release-1.12
jdleonard’s picture

jdleonard
he/him
Primary language English
Location Austin, Texas
commented
StatusFileSize
new secondary_button_contrast.png16.84 KB

Hmm, I had opened this issue here rather than on the uikit because there is no contrast issue with a link in an alert in storybook. Please let me know how to tell when to open here vs. uikit.

Screenshot showing secondary button contrast issue:
Screenshot showing secondary button link styling contrast issue

fionamorrison23’s picture

fionamorrison23 commented
Status: Closed (duplicate) » Active

@jdleonard I'll get back to you on this (as I need to update my own knowledge). regardless, I'm going to reopen this issue so we can apply Drupal credits to yourself as the reporter and any devs who work on it.