Problem/Motivation

When cron indexing is disabled for the index, the current UI implementation leads to headaches whenever you manually would like to index items, since the default batch size is retrieved from the `default_cron_limit` config key, which is 0 (which is the value to be used for disable cron indexing).

Steps to reproduce

Proposed resolution

When default_cron_limit is 0, fallback to 50 as default value.

Remaining tasks

Issue fork search_api-3521070

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mxr576 created an issue. See original summary.

mxr576 opened merge request !231

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Component: General code » User interface
Status: Active » Needs review

drunken monkey made their first commit to this issue’s fork.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +UX

Thanks for suggesting this change, makes sense.
However, wouldn’t it make more sense to default to the default cron limit? Though I guess that might also be 0, so there needs to be a last fallback of 50 regardless. Anyways, changed the code to try the default cron limit first.
Please test/review and tell me what you think!

(Note: Seems that, annoyingly, both user experience and UX are commonly used as tags, so changing to use both here. (The latter is significantly more common, though.))

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Sorry, I know there was a long delay since you created this, but would be great if you could still test/review before I merge it.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Sorry for the delayed response on this one, the fix works just fine. LGTM

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

No worries at all, thanks for reporting back and good to hear you are fine with my changes.
Merged.
Thanks again!

mansidrupalbliss’s picture

mansidrupalbliss commented

Thank you Thomas for fixing this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.