Blur on the auto-complete field sends stale data to update the preview

Interesting find! Not sure yet if this is a client-side or server-side bug. But since the server side renders the preview for the component tree it receives, I suspect it's the client side. If it's the server side, then I suspect it's in the auto-save functionality.

Hi
I tried to reporduce the issue but not able to reporcude the same.
I edited the button and followed the steps added above.
But in preview i can see the same text which we added.
please refer the screenshots

Thanks, @bhumikavarshney!

Definitely a bug! 👍 Thanks! 🙏

This is either a bug on the back-end (internal HTTP API or Auto-save), in the client-side handling of Auto-save, or in the Redux-integrated field widgets. Can you please attach the request body that was sent to generate that form when it was broken? 🙏

I was able to reproduce this! This is critical because of data loss.

When editing the Hero component that is bundled with XB

1. Update the values of some of the fields
2. Observe that the preview is updated with those changes
3. Focus into and then focus out of the "CTA 1 link" (autocomplete) field
4. Observe that, while the form values remain updated, the preview reverts back to before the changes made in step 1.

If you view the network request that occurs on blur you can see that the data sent as PATCH to the server contains the starting values of the form, not the updated ones.

Adding attributes.onChange in dependency array fixes the issue.

While this causes the effect to run multiple times as onChange reference update, but I think it's necessary to ensure event handlers always have access to the current state.

Or we could use useRef to fix the issue

diff --git a/ui/src/components/form/components/TextFieldAutocomplete.tsx b/ui/src/components/form/components/TextFieldAutocomplete.tsx
index 762e9b47..6ff8adee 100644
--- a/ui/src/components/form/components/TextFieldAutocomplete.tsx
+++ b/ui/src/components/form/components/TextFieldAutocomplete.tsx
@@ -1,6 +1,6 @@
 import clsx from 'clsx';
 import { TextField as RadixThemesTextField } from '@radix-ui/themes';
-import { forwardRef, useEffect, useImperativeHandle } from 'react';
+import { forwardRef, useEffect, useImperativeHandle, useRef } from 'react';
 import type { MutableRefObject } from 'react';
 import type { Attributes } from '@/types/DrupalAttribute';
 import styles from './TextField.module.css';
@@ -40,6 +40,12 @@ const TextFieldAutocomplete = forwardRef(
     attributes['data-xb-no-update'] = '';
 
     const inputRef = ref as MutableRefObject<HTMLInputElement>;
+    const onChangeRef = useRef(attributes.onChange);
+
+    // Update ref when onChange changes
+    useEffect(() => {
+      onChangeRef.current = attributes.onChange;
+    }, [attributes.onChange]);
 
     // Create a version of the ref that will appease Typescript.
     useImperativeHandle(ref, () => inputRef.current as HTMLInputElement);
@@ -55,7 +61,7 @@ const TextFieldAutocomplete = forwardRef(
       inputRef.current.removeAttribute('data-xb-no-update');
       setTimeout(() => {
         // Call the onChange listener so the Redux store is updated.
-        if (attributes?.onChange) {
+        if (onChangeRef.current) {
           const event = new Event('change');
 
           inputRef.current.value = e.detail.target.value;
@@ -63,8 +69,8 @@ const TextFieldAutocomplete = forwardRef(
             writable: false,
             value: inputRef.current,
           });
-          if (typeof attributes?.onChange === 'function') {
-            attributes.onChange(event);
+          if (typeof onChangeRef.current === 'function') {
+            onChangeRef.current(event);
           }
         }
       });
@@ -100,14 +106,14 @@ const TextFieldAutocomplete = forwardRef(
           // If the input is blurred, remove the attribute that prevents real
           // time preview updates.
           inputRef.current.removeAttribute('data-xb-no-update');
-          if (attributes?.onChange) {
+          if (onChangeRef.current) {
             const event = new Event('change');
             Object.defineProperty(event, 'target', {
               writable: false,
               value: inputRef.current,
             });
-            if (typeof attributes?.onChange === 'function') {
-              attributes.onChange(event);
+            if (typeof onChangeRef.current === 'function') {
+              onChangeRef.current(event);
             }
           }
         };

Or we could use useRef to fix the issue

Good idea. Lets do that to minimize useEffect, even if it means a bit of extra logic.

Added 3519734-ref-approach, first commit is an intentionally failing test and the second commit is a version of the ref approach suggested by @omkar-pd in #14

With @larowlan approval this can be merged.