Problem/Motivation

The cookies_docs_block plugin is missing a config schema

Steps to Reproduce

  • Install the 1.2.x branch
  • Place a cookie documentation block via block layout
  • Now check in the config inspector module, you can see the error related to this!!
CommentFileSizeAuthor
#2 block-plugin-config-schema-3519684.patch638 bytesralphvdhoudt

Issue fork cookies-3519684

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ralphvdhoudt created an issue. See original summary.

ralphvdhoudt’s picture

ralphvdhoudt commented
Status: Active » Needs review
StatusFileSize
new block-plugin-config-schema-3519684.patch638 bytes

This patch adds a config schema for the plugin to avoid config inspect errors about a missing schema

rakesh.regar made their first commit to this issue’s fork.

rakesh.regar opened merge request !131

divyansh.gupta’s picture

divyansh.gupta commented

Reviewing this!!

divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs review » Reviewed & tested by the community

I was able to reproduce this issue!!
Before applying the patch, there was a missing schema warning for settings.show_cookies_settings_button when checked using the Config Inspector module.
After applying the patch and clearing cache, the warning is gone, and everything is working as expected..
Changes looks good to me thus moving this to RTBC.

divyansh.gupta’s picture

divyansh.gupta commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil
grevil’s picture

grevil commented
Version: 1.2.x-dev » 2.x-dev
grevil’s picture

grevil commented
Assigned: grevil » Unassigned

Wrong Branch. But changes are correct, thx. I'll commit them directly since the MR needs manual local rebasing now.

  • grevil committed af47d3cb on 2.x 
    feat: #3519684 Block plugin is missing config schema
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.