Problem/Motivation

Keyboard navigation skips advanced fields.

graphic showing the advanced fields skipped by tabindex.

Steps to reproduce

  1. Enable Advanced Links attributes at Configuration > Content authoring > Text formats and editors > Basic HTML
  2. Create a Node, adding a link to the body
  3. Uncollapse the Advanced items
  4. Keyboard tab through the fields and see that it skips them.

Proposed resolution

Ensure the tabindex is correct.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork editor_advanced_link-3519379

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jcandan created an issue. See original summary.

jcandan’s picture

jcandan commented

This is a follow-up to #3371633-40: Exceptions thrown when toggling Advanced section of linking form.

jcandan’s picture

jcandan commented
Version: 2.2.x-dev » 2.x-dev

haritha c made their first commit to this issue’s fork.

vaish’s picture

vaish commented

In the branch 2.3.x this issue seems to be fixed by #3534699: [CKEditor5 v45+] Attributes can overwrite other attributes and editing displayed text from collapsed selection generates multiple links .

jcandan’s picture

jcandan commented
Version: 2.x-dev » 2.3.x-dev

Agreed. It seems this would be fixed by #3534699.

jannakha’s picture

jannakha commented
Status: Active » Needs review

please review MR 37 in https://www.drupal.org/project/editor_advanced_link/issues/3534699#comme...

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Needs review » Reviewed & tested by the community

Fixed as a part of #3534699: [CKEditor5 v45+] Attributes can overwrite other attributes and editing displayed text from collapsed selection generates multiple links .

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for contributions. 🎂
Merged and released. 🎁

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.