The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
See #3504381: [meta] Convert Template Preprocess hooks to OOP equivalent
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3519257-nr-bot.txt | 91 bytes | needs-review-queue-bot |
Issue fork drupal-3519257
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3519257-convert-templatepreprocesspager
changes, plain diff MR !11833
Comments
Comment #3
berdirComment #4
nicxvan commentedQuick comment on the constructor.
Any reason behind the file and function names being inverted?
Comment #5
berdir> Any reason behind the file and function names being inverted?
I assume you mean classname?
It's the same with all the Preprocess classes that I added. Class is FooPreprocess, and then the methods are preprocessFoo. with ThemeProcess it was just so that Foo wasn't the same thing so far.
Makes sense to me, for the class name it's just following naming rules (repeat last part of namespace if otherwise not providing enough context/being unique enough), while methods are verbThing.
Comment #6
nicxvan commentedYes, this needs a rebase, the other issue has the same failure.
Comment #7
berdirRebased.
Comment #8
smustgrave commentedTaking a guess here.
But applied the MR, setup a paginated view,
Pagination appears to be working.
The one thread about brackets probably can be a coding standard issue as sure there are other instances that may need to be fixed.
Comment #9
nicxvan commentedYeah I also carefully reviewed this, both with and without the zebra command git diff 11.x --color-moved=dimmed_zebra --color-moved-ws=ignore-all-space
The changes are comments and injections.
I retract my comments on the MR as @smustgrave and @berdir pointed out they belong in a coding standards issue.
Comment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
berdirRebased, it's been a while and had a bunch of conflicts with the field preprocess issue, so leaving at needs review for a confirmation.
Comment #12
nicxvan commentedOne suggestion on the deprecation and one question on the callback.
Comment #13
nicxvan commentedWent through this carefully, looks the same as the previous rtbc besides updating the deprecation.
Comment #14
catchCommitted/pushed to 11.x, thanks!
Comment #17
catch