Overview

Media library and other dialogs triggered by CKEditor 5 need to match the behavior of media library widgets opened in the Page Data / Component Instance forms. Without this, the appearance is unpredictable and some form fields might not work. Plus, it risks adding non-fenced admin theme styles to the XB UI due to the libraries added via the AJAX request

Proposed resolution

To manually test

See MR description

Issue fork experience_builder-3519141

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Data model
Status: Postponed » Active
Related issues: +#3512867: CKEditor 5 not loading on formatted text Field Widgets in the content entity form

#3512867: CKEditor 5 not loading on formatted text Field Widgets in the content entity form is in!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Dialogs opened by CKEditor5 need to be rendered with admin theme » Dialogs opened by CKEditor 5 need to be rendered with admin theme
Component: Data model » Redux-integrated field widgets
Issue tags: +stable blocker

IDK what happened there 😅

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Parent issue: » #3519910: [META] WYSIWYG in Experience Builder

bnjmnm opened merge request !925

wim leers credited larowlan.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » bnjmnm
Status: Active » Needs work
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Assigned: bnjmnm » Unassigned
Status: Needs work » Needs review

hooroomoo made their first commit to this issue’s fork.

f.mazeikis’s picture

f.mazeikis commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested - seems to work as expected.

  • bnjmnm committed fb567856 on 0.x 
    Issue #3519141 by bnjmnm, larowlan: Dialogs opened by CKEditor 5 need to...
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thx for reviews everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.