Fix ArgumentCountError in VarbaseMediaHeaderSettingsForm constructor [#3518954]

Problem/Motivation

An error appears when trying to open the Varbase Media Header settings page.

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/docroot/modules/contrib/varbase_media_header/src/Form/VarbaseMediaHeaderSettingsForm.php on line 66 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

Steps to reproduce

Install the Varbase Media Header module on a Varbase site using Drupal 11.
Enable the module.
Navigate to /admin/config/varbase/varbase-media-header.
An error appears on the page.

Proposed resolution

Resolve the compatibility issue between the custom class and the ConfigFormBase class.

Remaining tasks

✅ File an issue about this project
✅ Addition/Change/Update/Fix to this project
✅ Testing to ensure no regression
➖ Automated unit/functional testing coverage
➖ Developer Documentation support on feature change/addition
➖ User Guide Documentation support on feature change/addition
➖ UX/UI designer responsibilities
➖ Accessibility and Readability
✅ Code review from 1 Varbase core team member
✅ Full testing and approval
✅ Credit contributors
✅ Review with the product owner
✅ Update Release Notes and Update Helper on new feature change/addition
✅ Release varbase-10.1.0-alpha2, varbase-10.0.5, varbase_media_header-10.0.4, varbase_media_header-10.0.5, varbase-9.1.10, varbase_media_header-9.1.8, varbase_media_header-9.1.9

Varbase update type

✅ No Update
➖ Optional Update
➖ Forced Update
➖ Forced Update if Unchanged

User interface changes

API changes

Data model changes

Release notes snippet

Issue #3518954 by qusai taha, ahmad khader: Fixed ArgumentCountError in VarbaseMediaHeaderSettingsForm constructor

Comment	File	Size	Author
#2	3518954-2.patch	2.64 KB	qusai taha

Issue fork varbase_media_header-3518954

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3518954-fix-issue-argumentcounterror changes, plain diff MR !7
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

13 April 2025 at 12:05

qusai taha created an issue. See original summary.

Comment #2

qusai taha commented 13 April 2025 at 12:06

Assigned:	qusai taha	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	3518954-2.patch	2.64 KB

Comment #3

13 April 2025 at 12:08

qusai taha opened merge request !7

Comment #4

rajab natshah

he/him

commented 14 April 2025 at 11:21

Title:

Fix Issue ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(),

» Fix ArgumentCountError in VarbaseMediaHeaderSettingsForm constructor

Comment #5

rajab natshah

he/him

commented 14 April 2025 at 11:21

Comment #6

14 April 2025 at 11:23

rajab natshah committed 479876fa on 10.0.x authored by qusai taha
```
Issue #3518954 by qusai taha: Fix ArgumentCountError in...
```

Comment #7

14 April 2025 at 11:32

rajab natshah committed d5c15bdd on 10.1.x authored by qusai taha
```
Issue #3518954 by qusai taha: Fix ArgumentCountError in...
```

Comment #8

rajab natshah

he/him

commented 14 April 2025 at 11:37

Assigned:	Unassigned	» s.halawani
Issue summary:	View changes
Issue tags:		+varbase-10.0.5, +varbase_media_header-10.0.4

Comment #9

rajab natshah

he/him

commented 14 April 2025 at 12:13

Assigned:	s.halawani	» rajab natshah
Status:	Needs review	» Needs work

Fixed to work with Drupal 11
But facing the following issues in Drupal 10

PHP Fatal error:  Type of Drupal\varbase_media_header\Form\VarbaseMediaHeaderSettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) in /app/docroot/modules/contrib/varbase_media_header/src/Form/VarbaseMediaHeaderSettingsForm.php on line 22
 [error]  RuntimeException: Recursive router rebuild detected. in Drupal\Core\Routing\RouteBuilder->rebuild() (line 121 of /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php) #0 /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php(210): Drupal\Core\Routing\RouteBuilder->rebuild()
#1 /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php(222): Drupal\Core\Routing\RouteBuilder->rebuildIfNeeded()
#2 /app/docroot/core/lib/Drupal/Core/DrupalKernel.php(723): Drupal\Core\Routing\RouteBuilder->destruct()
#3 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(314): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#4 [internal function]: Drush\Boot\DrupalBoot8->terminate()
#5 {main}. 
RuntimeException: Recursive router rebuild detected. in /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php on line 121 #0 /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php(210): Drupal\Core\Routing\RouteBuilder->rebuild()
#1 /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php(222): Drupal\Core\Routing\RouteBuilder->rebuildIfNeeded()
#2 /app/docroot/core/lib/Drupal/Core/DrupalKernel.php(723): Drupal\Core\Routing\RouteBuilder->destruct()
#3 /app/vendor/drush/drush/src/Boot/DrupalBoot8.php(314): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Render\HtmlResponse))
#4 [internal function]: Drush\Boot\DrupalBoot8->terminate()
#5 {main}
RuntimeException: Recursive router rebuild detected. in Drupal\Core\Routing\RouteBuilder->rebuild() (line 121 of /app/docroot/core/lib/Drupal/Core/Routing/RouteBuilder.php).

PHP Fatal error:  Type of Drupal\varbase_media_header\Form\VarbaseMediaHeaderSettingsForm::$typedConfigManager must not be defined (as in class Drupal\Core\Form\ConfigFormBase) in /app/docroot/modules/contrib/varbase_media_header/src/Form/VarbaseMediaHeaderSettingsForm.php on line 22
 [warning] Drush command terminated abnormally.

Comment #10

rajab natshah

he/him

commented 14 April 2025 at 12:13

Status:

Needs work

» Active

Comment #11

14 April 2025 at 12:26

rajab natshah committed d43dec67 on 10.1.x

Issue #3518954: Fix Recursive router rebuild detected for the defined...

Comment #12

14 April 2025 at 12:28

rajab natshah committed c73abf2d on 10.0.x

Issue #3518954: Fix Recursive router rebuild detected for the defined...

Comment #13

rajab natshah

he/him

commented 14 April 2025 at 12:36

Assigned:	rajab natshah	» Unassigned
Status:	Active	» Fixed

Comment #14

rajab natshah

he/him

commented 14 April 2025 at 12:58

Issue summary:

View changes

✅ Released varbase_media_header-10.0.4

Comment #15

rajab natshah

he/him

commented 14 April 2025 at 13:22

Issue summary:	View changes
Issue tags:		+varbase-9.1.10, +varbase_media_header-9.1.8

✅ Released varbase_media_header-9.1.8

Comment #16

ahmad khader commented 15 April 2025 at 07:25

@Rajab,
i'm still receiving PHP Fatal error: Type of Drupal\varbase_media_header\Form\VarbaseMediaHeaderSettingsForm::$typedConfigManager changing protected $typedConfigManager; to protected TypedConfigManagerInterface $typedConfigManager; fixed it.

Comment #17

rajab natshah

he/him

commented 15 April 2025 at 08:01

Drupal 10 or Drupal 11?
PHP version? PHP 8.3 or something else?
DDEV, Lando, or LAMP?

Comment #18

rajab natshah

he/him

commented 15 April 2025 at 12:18

Thanks, Ahmad, for following up and reporting!

I confirm the issue

I found what wrong
No need to define ( protected $typedConfigManager; )
and the order to pass in the __construct

ConfigFormBas, and ConfigFormBaseTrait has protected passed to the __construct

Committing and doing a quick fix release.

Comment #19

15 April 2025 at 12:19

rajab natshah committed 8147f858 on 10.1.x

Issue #3518954: Fix ArgumentCountError in VarbaseMediaHeaderSettingsForm...

Comment #20

15 April 2025 at 12:20

rajab natshah committed 7c05bbaf on 10.0.x

Issue #3518954: Fix ArgumentCountError in VarbaseMediaHeaderSettingsForm...

Comment #21

15 April 2025 at 12:22

rajab natshah committed 506b40ad on 9.1.x

Issue #3518954: Fix ArgumentCountError in VarbaseMediaHeaderSettingsForm...

Comment #22

15 April 2025 at 12:22

rajab natshah committed 74860739 on 9.1.x authored by qusai taha

Issue #3518954 by qusai taha: Fix ArgumentCountError in...

Comment #23

rajab natshah

he/him

commented 15 April 2025 at 14:22

Issue summary:	View changes
Issue tags:		+varbase_media_header-10.0.5, +varbase_media_header-9.1.9

Comment #24

rajab natshah

he/him

commented 15 April 2025 at 14:23

✅ Released varbase_media_header-10.0.5

Comment #25

rajab natshah

he/him

commented 15 April 2025 at 14:25

✅ Released varbase_media_header-9.1.9

Comment #26

rajab natshah

he/him

commented 21 April 2025 at 12:53

Issue summary:

View changes

✅ Released varbase-10.0.5

Comment #27

5 May 2025 at 12:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #28

rajab natshah

he/him

commented 5 July 2025 at 18:32

Issue summary:

View changes

✅ Released varbase-9.1.10

Comment #29

rajab natshah

he/him

commented 4 August 2025 at 17:07

Issue summary:

View changes

✅ Released varbase-10.1.0-alpha2