Auto-increment needed for D6 ? [#351886]

I have found problems adding queues to my recently upgraded D5 install to D6. Queue id (qid) assigned to new queues is always 0 (so I just can add one queue, that also has lot of functional problems...)

I am not very familiar with nodequeue code and D6 enough to be completely sure to state this, but looking at the nodequeue.install code I haven't found an autoincrement value for nodequeue_queue and nodequeue_subqueue tables regarding qid and sqid keys. Taking into account D6 does not use sequences table any more, that seems to be the root cause of the problem.

But it sounds strange to me, as if this is true, adding queues to nodequeue wouldn't work for anybody using D6...

Can anyone explain this issue, or confirm it?

Comment	File	Size	Author
#8	351886.patch	1.26 KB	ezra-g
#8

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dawehner

German

CreditAttribution: dawehner commented 28 December 2008 at 23:26

did you run update.php? because the qid field is there changed to a serial field

Comment #2

pedropablo CreditAttribution: pedropablo commented 28 December 2008 at 23:31

BTW, adding autoincrement to qid and sqid columns (using myphpadmin) solved the problem.

Comment #3

ezra-g CreditAttribution: ezra-g commented 29 December 2008 at 02:25

Status:

Active

» Postponed (maintainer needs more info)

Can you comment on whether you ran update.php before you experienced this problem?

Comment #4

pedropablo CreditAttribution: pedropablo commented 30 December 2008 at 10:23

Yes, I did run update.php and the update was applied. Looking at my old db copy, the previous schema version was 5204 (with a very different install file by merlinofchaos) and there were nothing about autoincrement for mysql.

I am not a coder, but looking into updates 6000 and 6001, neither of them seems to change those columns to serialized ones... and I as far as I understand, the schema can only be changed by updates, Is that right? Maybe my 5204 version should have been previously serialized?

thank you for your help :-)

Comment #5

pedropablo CreditAttribution: pedropablo commented 30 December 2008 at 15:39

Status:

Postponed (maintainer needs more info)

» Active

Comment #6

Jody Lynn

she/her

English

CreditAttribution: Jody Lynn commented 5 January 2009 at 22:59

We ran into the same thing today- had to add auto_increment manually to nodequeue_queue. Didn't look like there was an update for it in the 6.x updates.

Comment #7

ezra-g CreditAttribution: ezra-g commented 5 January 2009 at 23:06

Priority:

Normal

» Critical

Thanks, everyone, for identifying this problem. Glad we found it before the next RC, which I'd like to push out this week. Marking as critical since it prevents user from upgrading from D5.

Comment #8

ezra-g CreditAttribution: ezra-g commented 6 January 2009 at 15:53

Status:

Active

» Fixed

File	Size
351886.patch	1.26 KB

I just committed this change and updated a Drupal 5 install with Nodequeue to D6, and this successfully added the auto_increment primary keys and worked in my testing. Thanks again, everyone!