Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Redux-integrated field widgets
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Apr 2025 at 21:24 UTC
Updated:
13 May 2025 at 16:14 UTC
Jump to comment: Most recent
Comments
Comment #4
omkar-pd commentedComment #5
penyaskitoComment #6
omkar-pd commentedComment #7
larowlanPushed the required fix here.
The nuance is this in
FormBuilder::handleInputElementWith
\Drupal\experience_builder\ClientDataToEntityConverter::setEntityFieldswe're doing a$form_state->setProgrammed()so that set value never happens. Therefore the old code that was unsetting (or rather filtering out) unticked checkboxes actually needs to be setting them to NULL rather than removing them.With that change in place, the test passes 🙌
Comment #9
bnjmnmThe MR looks good, but could this be expanded to include a checkbox with a default value unchecked, in addition to the existing one with
['value' => 1],?Comment #10
wim leers#9: great call! This one is tantalizingly close!
Comment #11
larowlanRebased, addressed review comments and #9
Comment #13
wim leers@bnjmnm's feedback in #9 has been addressed 👍
Comment #15
wim leersComment #16
wim leersLooks like this somehow caused consistent failures in
entity-form-field-types-test.cy.jsdespite multiple CI runs on this MR being green— see https://git.drupalcode.org/project/experience_builder/-/commit/bc8ce91c5....Comment #18
wim leersOMG I AM AN IDIOT 😭🙈
Comment #19
wim leersBen's my hero of the day! 🦸
Comment #21
wim leersThanks so much!