Problem/Motivation

This would add default code quality checks on merge requests.

Issue fork group_subscription-3516936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

majorrobot created an issue. See original summary.

majorrobot opened merge request !12

majorrobot’s picture

majorrobot commented
Status: Active » Needs review

Added in the MR!

jaydarnell’s picture

jaydarnell
he/him
Primary language English
Location Guelph, Ontario
commented

Thanks @majorrobot. I'll try to give this a review this weekend.

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thank you @majorrobot. I can see the GitLab CI run. Hi @jaydarnell, probably will need a follow-up ticket to fix phpcs and related issues.

jaydarnell’s picture

jaydarnell
he/him
Primary language English
Location Guelph, Ontario
commented

Thanks @majorrobot and @dmundra. I've merged this work and will start working on fixes for the items identified by circleCI.

jaydarnell’s picture

jaydarnell
he/him
Primary language English
Location Guelph, Ontario
commented
Status: Reviewed & tested by the community » Fixed
dmundra’s picture

dmundra
he/him
Primary language English
commented

Thank you @jaydarnell

jaydarnell’s picture

jaydarnell
he/him
Primary language English
Location Guelph, Ontario
commented
Issue tags: +Group Subscription 3.1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.