Problem/Motivation

Want to automatically run default code quality checks on merge requests along with (hopefully in the future) automated tests.

Issue fork media_link_enhancements-3516929

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jastraat created an issue. See original summary.

jastraat opened merge request !9

jastraat’s picture

jastraat commented
Status: Active » Needs review
jastraat’s picture

jastraat commented

For right now, running GitLab CI only in Drupal 10. Once we add support for Drupal 11, we should remove the following line from the gitlab file:
OPT_IN_TEST_CURRENT: 0

jastraat’s picture

jastraat commented
Related issues: +#3516940: Code quality updates
dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thank you @jastraat. I can see the GitLab CI pipeline run without issue.

jastraat’s picture

jastraat commented
Status: Reviewed & tested by the community » Needs review

This needs to reviewed again I think -

dmundra’s picture

dmundra
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Changes look good @jastraat, thank you!

  • jastraat committed 00cbdc56 on 1.0.x 
    feat: #3516929 Add GitLab CI

By: jastraat
jastraat’s picture

jastraat commented
Status: Reviewed & tested by the community » Fixed

Thank you @dmundra!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.