Problem/Motivation

This module is not compatible with Drupal 11.

Steps to reproduce

Proposed resolution

I scanned it with upgrade_status and it looks like the only deprecation is this in ForwardLinkFormatter.php:

Call to deprecated function file_validate_is_image(). Deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Use the 'file.validator' service instead.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork forward-3516841

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

prudloff created an issue. See original summary.

prudloff opened merge request !6

prudloff’s picture

prudloff commented
Status: Active » Needs review

We don't need to duplicate the drupal/core requirement in composer.json, drupal.org generates it based on core_version_requirement when creating the Composer package.

john_b made their first commit to this issue’s fork.

john_b’s picture

john_b commented

I made further changes required to get the module working with D11.

brunodbo’s picture

brunodbo
he/him
commented
Status: Needs review » Reviewed & tested by the community

Upgrade Status reports the module as compatible with Drupal 11 after applying changes. Manually tested the module, all good.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Needs work

  • dww committed a4b4f75e on 4.0.x 
    task: #3516841 Drupal 11 compatibility (still works with D10, but had to...

dww closed merge request !6

dww’s picture

dww
we/he/they
commented
Status: Needs work » Fixed

This was more broken that I had thought. Ended up having to do more with the event dispatcher stuff. Plus, we all missed that forward_test.info.yml needed to be fixed, too. Glad I got #3579177: Enable GitLab CI and fix pipelines resolved earlier today! Gives me a lot more confidence.

Did a little experimenting with the .gitlab-ci.yml config to see what the unreported deprecations were when running the phpunit tests on D11. It's all new deprecations in D11 to prepare for D12 or even D13. Left that configuration as a separate, manually-triggered phpunit-all-deprecations job:

https://git.drupalcode.org/project/forward/-/pipelines/768826
https://git.drupalcode.org/project/forward/-/jobs/8919365

I'm not worried about trying to fix any of that stuff, yet. 😅 Given that both phpstan and phpunit are happy when run against 11.3.x, I went ahead and merged this to 4.0.x.

Since I *just* cut the 4.0.3 release, and I don't actually need the D11 support immediately for the site I'm working on this for, I'm going to let this simmer in the -dev release for a few days. If anyone is available to do more manual testing, that'd be great! If there are no signs of trouble, I'll cut 4.0.4 to drop D9 and add D11 in the coming days/weeks (but not months/years).

Thanks!
-Derek

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jason_purdy’s picture

jason_purdy commented

any update on when the 4.0.4 version will be released for full D11 support?

dww’s picture

dww
we/he/they
commented

@jason_purdy: Did you do any testing of the -dev release? Would be helpful to confirm before tagging a stable release.

jason_purdy’s picture

jason_purdy commented

I did and it worked great on my local box.

dww’s picture

dww
we/he/they
commented
Version: 4.0.x-dev » 4.0.4

Great, thanks.

https://www.drupal.org/project/forward/releases/4.0.4