Problem/Motivation

TagManager.php is calling parent::__construct() like this:

parent::__construct(FALSE, $namespaces, $module_handler, $cache_backend);

However, the 4th argument of that method is the plugin interface:

public function __construct($subdir, \Traversable $namespaces, ModuleHandlerInterface $module_handler, $plugin_interface = NULL, ?string $plugin_definition_attribute_name = NULL, string|array|null $plugin_definition_annotation_name = NULL, array $additional_annotation_namespaces = [])

This is breaking some drush commands I have; not sure what else would be affected by this.

Steps to reproduce

Run drush gen phpstorm-meta

Proposed resolution

Fix construct method in TagManager

CommentFileSizeAuthor
#3 3515890fix-constructor-args.patch776 bytesdabblela
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dabblela created an issue. See original summary.

dabblela’s picture

Status: Active » Needs review
StatusFileSize
new776 bytes

dabblela changed the visibility of the branch 3515890-tagmanager-calls-parentconstruct to hidden.

apmsooner made their first commit to this issue’s fork.

apmsooner’s picture

Status: Needs review » Fixed

Thanks for the patch. Merged!

  • apmsooner committed 6031217d on 3.1.x authored by dabblela
    Issue #3515890 by dabblela: TagManager calls parent::__construct() with...
apmsooner’s picture

Status: Fixed » Closed (fixed)