Problem/Motivation

Fix eslint issues reported by CI pipeline

Issue fork faqfield-3515259

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ggh created an issue. See original summary.

ggh opened merge request !10

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Active » Needs work

There are still some eslint failures.

shamir.vs made their first commit to this issue’s fork.

shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review

I have created a merge request that fixes the failed pipeline errors. Please take a moment to review it. Thank you!

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs a rebase.

shamir.vs’s picture

shamir.vs commented
Status: Needs work » Needs review

I have rebased. Kindly review

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.0.0 » 8.0.x-dev

Posted feedback on the MR.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Also, merge conflicts still seem to exist.

shamir.vs’s picture

shamir.vs commented

I have addressed the feedback on the merge request and resolved the conflicts. Please review it.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.0.x-dev » 8.0.0
Status: Needs review » Fixed

Thanks for the improvements here.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • heddn committed c7c5b361 on 8.0.x authored by ggh 
    chore: #3515259 Fix eslint issues

By: heddn
By: shamir.vs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.