Problem/Motivation

The stylelint check is not passing.

Proposed resolution

Fix issues raised by stylelint.

Remaining tasks

Merge.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork page_manager-3514064

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9 opened merge request !40

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Needs review

Both phpcs and stylelint are green.

The failing tests are addressed in:

magdalenaa67’s picture

magdalenaa67 commented

page_manager-3514064.patch worked for me. Thank you!

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The merge request makes many changes that are not about nullable params, as described in the issue title. I suggest leaving the nullable params to #3536704: [PHP8.4] Misc NULL deprecation warning on a few files and re-title this issue to be about coding standards.

joelpittet made their first commit to this issue’s fork.

vinodhini.e’s picture

vinodhini.e commented

Hi, Hi,

Tested this on Drupal 11.2.5 and verified the coding standards using PHPCS and Stylelint.

After applying MR #40 and re-running the reports:

PHPCS is not reporting any errors.
Stylelint is still reporting 14 errors, listed below.

File: web/modules/contrib/page_manager-3514064/page_manager_ui/css/page-manager-ui-page-variants.css

Line 7: Expected class selector ".page__section__2" to be kebab-case (selector-class-pattern)
Line 11: Expected class selector ".page__section__2" to be kebab-case (selector-class-pattern)
Line 15: Expected class selector ".page__section_item__1" to be kebab-case (selector-class-pattern)
Line 15: Expected class selector ".page__section__label" to be kebab-case (selector-class-pattern)
Line 20: Expected class selector ".page__section_item__1" to be kebab-case (selector-class-pattern)
Line 20: Expected class selector ".page__section__label" to be kebab-case (selector-class-pattern)
Line 26: Expected class selector ".page__section_item__1" to be kebab-case (selector-class-pattern)
Line 27: Expected class selector ".page__section__label" to be kebab-case (selector-class-pattern)
Line 32: Expected class selector ".page__section_item__1" to be kebab-case (selector-class-pattern)
Line 33: Expected class selector ".page__section__label" to be kebab-case (selector-class-pattern)
Line 33: Expected class selector ".current_variant" to be kebab-case (selector-class-pattern)

File: web/modules/contrib/page_manager-3514064/page_manager_ui/css/page-manager-ui.admin.css

Line 49: Expected selector ".page-manager-wizard-tree > ul" to come before selector ".page-manager-wizard-tree ul > li > ul" (no-descending-specificity)
Line 55: Expected selector ".page-manager-wizard-tree li" to come before selector ".page-manager-wizard-actions ul.inline li" (no-descending-specificity)
Line 61: Expected selector ".page-manager-wizard-tree li:last-child" to come before selector ".page-manager-wizard-actions ul.inline li" (no-descending-specificity)

Thanks.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Implicitly marking parameter as nullable is deprecated » Fix issues raised by stylelint
Issue summary: View changes

I have updated the merge request so that it is only fixing issues raised by stylelint. That test now passes. phpcs already passes and there are already no implicit nullable params.

@bluegeek9 Please re-title the merge request. You can change it because you are the creator.

  • joelpittet committed d5edd6bf on 8.x-4.x authored by bluegeek9 
    chore: #3514064 Fix issues raised by stylelint

By: bluegeek9
By: liam...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thanks for rescoping this @lkmorlan and @bluegeek9 for the initial MR

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.