Convert experimental_module_requirements_test_requirements to new Class [#3513879]

Problem/Motivation

There was a failure when converting install time hooks so I moved converting that to this issue.

Steps to reproduce

Convert experimental_module_requirements_test_requirements to InstallRequirements.php

Proposed resolution

Convert this as install time only
This is only tested in core/modules/system/tests/src/Functional/Module/NonStableModulesTest.php so there is no need to run this check in runtime or update.

Remaining tasks

Should we remove the state change, I think that was due to another test that this module is no longer used in.
This test is marked as experimental, but it literally only tests that it cannot be installed with the requirements error, we have other test coverage, should this be changed to actually test something to do with experimental.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#6	3513879-nr-bot.txt	91 bytes	needs-review-queue-bot

Issue fork drupal-3513879

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3513879-convert-experimentalmodulerequirementstestrequirements-to

changes, plain diff MR !11938

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

19 March 2025 at 03:41

nicxvan created an issue. See original summary.

Comment #2

25 April 2025 at 02:04

nicxvan opened merge request !11938

Comment #3

nicxvan commented 25 April 2025 at 02:07

Issue summary:	View changes
Status:	Active	» Needs review

Comment #4

smustgrave commented 7 May 2025 at 15:30

Status:	Needs review	» Reviewed & tested by the community
Issue tags:		+Needs Review Queue Initiative

Seems like a good conversion

Comment #5

dww

we/he/they

commented 8 May 2025 at 22:15

Parent issue:

» #3490845: [meta] Convert hook_requirements to new class or hook_update_requirements or hook_runtime_requirements

Giving this its proper parent.

Agree this is RTBC. Small changes. The new class implementation is identical to the old procedural version. The comments look fine. I might split hairs, but it's not worth it. 😂

Thanks!
-Derek

Comment #6

needs-review-queue-bot commented 24 May 2025 at 19:37

Status:

Reviewed & tested by the community

» Needs work

Status	File	Size
new	3513879-nr-bot.txt	91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.