Problem/Motivation

For GraphQL 5.0 we want all our types as strict as possible and leverage PHP type features.

Proposed resolution

  1. Enforce types in PHPCS and/or PHPStan.
  2. Add declare strict types everywhere

Any further fine-tuning or changing function signatures should be done in a follow-up, to not make this too big.

Remaining tasks

Finish PR.

User interface changes

none

API changes

Interfaces and classes will change and can cause breaking changes.

Data model changes

none

Issue fork graphql-3513159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

klausi created an issue. See original summary.

klausi’s picture

Version: 8.x-4.x-dev » 5.x-dev
Parent issue: » #3513158: Release GraphQL 5.0

klausi’s picture

Issue summary: View changes
Status: Active » Needs review

Unfortunately this is quite a big change, the important thing is to review the interfaces so that they are solid.

klausi credited kingdutch.

klausi’s picture

Status: Needs review » Fixed

I merged this now - we can do anything that is unclear or could be improved in follow-ups. Better we get this big change out of the way now so that we can work better on other improvements.

  • klausi committed e0b97ba8 on 5.x
    refactor(php): Add types everywhere (#3513159)
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.