Problem/Motivation

Current code that is calculating IDs of menu items is buggy and it will produce duplicate IDs.

Issue fork bs_base-3512865

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pivica created an issue. See original summary.

pivica opened merge request !17

pivica’s picture

pivica commented
Status: Active » Needs review

MR ready for testing.

pivica’s picture

pivica commented

This change broke aria-labelledby a bit. But we can also simplify its value now and just use parent_id var which we added in previous commit. True we will not reference all the parents of menu item, but just the first one, but I think there is not too much benefit of referencing them all in the first place, lets see. This is fixed in https://git.drupalcode.org/project/bs_base/-/merge_requests/17/diffs?com....

  • pivica committed 1eac75d5 on 8.x-1.x 
    Issue #3512865 by pivica: Navbar menu links duplicated IDs
pivica’s picture

pivica commented
Status: Needs review » Fixed

Merged.

  • pivica committed 1eac75d5 on 2.0.x 
    Issue #3512865 by pivica: Navbar menu links duplicated IDs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.