Problem/Motivation

The readme is still based on the D7 version, it needs to be updated for D10+

Also, hook_help.

CommentFileSizeAuthor
#8 hook_help-after.png212.82 KBroberttabigue
#8 hook_help-before.png280.37 KBroberttabigue
#8 README.txt5.58 KBroberttabigue

Issue fork jstimer-3511702

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aaron.ferris created an issue. See original summary.

nexusnovaz made their first commit to this issue’s fork.

nexusnovaz opened merge request !13

nexusnovaz’s picture

nexusnovaz commented
Status: Active » Needs review

Hey, please review MR !13. I'm unsure if i need to add more information to the readme or the help page, but this is a good start i believe

aaron.ferris’s picture

aaron.ferris commented

Thanks looks good, couple of comments.

aaron.ferris’s picture

aaron.ferris commented
Status: Needs review » Needs work
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs work » Needs review
roberttabigue’s picture

roberttabigue commented
StatusFileSize
new README.txt5.58 KB
new hook_help-before.png280.37 KB
new hook_help-after.png212.82 KB

Hi,

After applying MR!13 on the Javascript Time module (2.0.x-dev) on my local Drupal setup, confirmed the README.md is now updated, as well as the hook_help.

Please see the attached files for reference.

I'm moving this now to "RTBC".

Thank you!

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.