Problem/Motivation

We have declaration issue:

Fatal error: Declaration of Drupal\ai_ckeditor\Plugin\AICKEditor\FleschScore::buildCkEditorModalForm(array $form, Drupal\Core\Form\FormStateInterface $form_state) must be compatible with Drupal\ai_ckeditor\AiCKEditorPluginBase::buildCkEditorModalForm(array $form, Drupal\Core\Form\FormStateInterface $form_state, array $settings = []) in /home/www/subsites/web/modules/contrib/ai_ckeditor_extras/src/Plugin/AiCKEditor/FleschScore.php on line 58

Steps to reproduce

The steps to reproduce the error are:

  • Install via composer the module alpha1
  • Enable module
  • Configure the text format
  • Save the text format
  • Try to edit configuration of the text format, an error is arisen

Proposed resolution

A the function declaration, add the missing third parameter

Remaining tasks

The list of tasks:

  • Create a patch
  • Fork the code
  • Add the fix at code

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 ai_ckeditor_extra_issue.patch1 KBmok7tar
#2 ai_ckeditor_extra_issue.patch818 bytesmok7tar
ai_ckeditor_extra_issue.patch822 bytesmok7tar

Issue fork ai_ckeditor_extras-3511319

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mok7tar created an issue. See original summary.

mok7tar’s picture

mok7tar commented
StatusFileSize
new ai_ckeditor_extra_issue.patch818 bytes
mok7tar’s picture

mok7tar commented
StatusFileSize
new ai_ckeditor_extra_issue.patch1 KB
mok7tar’s picture

mok7tar commented
abelcain’s picture

abelcain commented
Assigned: mok7tar » abelcain
Issue summary: View changes

abelcain opened merge request !3

abelcain’s picture

abelcain commented
Assigned: abelcain » escuriola

Please Carlos, merge ready, review and let's close this issue and move forward. Many thanks in advance.

enriquelacoma’s picture

enriquelacoma commented
Assigned: escuriola » enriquelacoma
enriquelacoma’s picture

enriquelacoma commented
Status: Active » Reviewed & tested by the community

enriquelacoma’s picture

enriquelacoma commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

enriquelacoma’s picture

enriquelacoma commented
Status: Fixed » Closed (fixed)