Problem/Motivation

In the parent issue we validate a Role Exists. this could be more specific in this specific case where we check if the user has the role. Although im not sure that needs to be an error, since you might just want to remove a role from all users.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Comments

bbrala created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes

The parent issue was committed.

Since it's about removing a role, I'm not sure if we need to have strict validation.
However it could lead to an action that doesn't do anything when it has a role configured that does not exist I guess.

bbrala’s picture

bbrala
Location Netherlands
commented

I kinda agree that a noop might not really be a problem.

quietone’s picture

quietone commented
Title: [Follow-up] action.configuration.user_remove_role_action could also use a UserHasRole constaint » action.configuration.user_remove_role_action could also use a UserHasRole constaint
Status: Active » Postponed (maintainer needs more info)

Is this still needed?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

I think we can close this issue. I don't think adding this validation adds much value to the system.

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Lets do it ;)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.