Problem/Motivation

The module uses the global $base_url to determine whether to show the pop-up:

    global $base_url;

    $domains_list = str_replace(["\r\n", "\r"], "\n", $config->get('domains_list'));
    $domains_list = explode("\n", $domains_list);
    $domains_list = preg_replace('{/$}', '', $domains_list);
    $domain_match = in_array($base_url, $domains_list);

However, $base_url can also include subfolders if that's where Drupal is installed. For example on my local dev, Drupal is at:

> http://localhost:8888/waltham-current/web

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3507411-test2.png55.15 KBdanrod
#4 3507411-test1.png1.42 MBdanrod
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

joachim created an issue. See original summary.

danrod’s picture

Assigned: Unassigned » danrod
danrod’s picture

I'd like to look on this one.

danrod’s picture

StatusFileSize
new1.42 MB
new55.15 KB

Hello, I had a look on this and I'm not sure what needs to be fixed here, I tested this on a site installed in a subfolder (https://subsite.ddev.site/maresmuseum/e) and worked fine to me:

Cookie subfolder

This is the contents of the "Domains List" field:

Cookie subfolder 2

I'm setting this issue as "Needs Review" for now, but I am not sure what is the problem, it is working fine out of the box for me.

danrod’s picture

Status: Active » Needs review
atowl’s picture

Status: Needs review » Postponed (maintainer needs more info)

Hi @joachim,

Think we need more information, and possibly a good reproduction to see whats going on here.

atowl’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

With no further information, i'm closing this.

Please feel free to reopen if its still an issue

atowl’s picture