Problem/Motivation

Just like this: https://photoswipe.com/adding-ui-elements/#adding-download-button

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork photoswipe-3506399

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

+1 for this. We need this in a current project. @anybody: maybe a job for @lrwebks?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

I think better for @grevil. Please assign him in a CU issue for this with details.

grevil made their first commit to this issue’s fork.

grevil opened merge request !150

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

All done, please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » thomas.frobieter

RTBC from my side. Just the "Download" text should be added for screen readers maybe (if very easily possible). I left a comment for @thomas.frobieter to check that.

Let @thomas.frobieter do the final review (looking at the JS). I'm also fine with merging immediately.

grevil’s picture

grevil commented
Assigned: thomas.frobieter » anybody
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
Status: Needs review » Reviewed & tested by the community

Perfect!

  • grevil committed 2432ba6f on 5.x 
    feat: #3506399 Add a setting to show a download button in Photoswipe...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.