Problem/Motivation

When using the latest, once you enable the event_platform_olivero module, and if you go to the Block layout section, you find a block has "Broken/Missing". Tracing the id it leads to "session_list-page_1".

Proposed resolution

Expose the form as a block fixes it.

Issue fork event_platform-3506379

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !11

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review
kurttrowbridge’s picture

kurttrowbridge
he/him
commented
Issue tags: +#fldc25

(Hello! Looking at this while at Florida DrupalCamp.)

The fix in the MR does prevent the block from being broken/missing. I was also initially seeing that as a warning when first installing Event Platform Olivero from the command line as its dependent modules were enabled ([warning] The "views_exposed_filter_block:session_list-page_1" block plugin was not found), and that's no longer present.

Question, though: when I first install Event Platform, I see the sessions page located at /sessions. The exposed block's config is set to appear on /session-list and its child pages, which don't exist upon the initial install. Should I expect to see those pages, or should the path visibility conditions for the block be updated?

mandclu’s picture

mandclu commented

@kurttrowbridge great catch. TBH I think the exposed block placement configuration in event_platform_olivero is vestigial config from before the view was updated in this commit. As such, I think we should delete that file and leave the form not exposed. I'll open up a new MR with this approach.

mandclu opened merge request !12

mandclu’s picture

mandclu commented

@kurttrowbridge if you could review the new MR, that would be helpful

kurttrowbridge’s picture

kurttrowbridge
he/him
commented
Status: Needs review » Reviewed & tested by the community

Installed fresh with the patch in place, I confirmed that the missing block warning didn't appear as I enabled Event Platform Olivero, that there isn't a missing block on the block layout page, and that the Sessions page still displays its exposed filters. Looks good to me!

  • mandclu committed 6634d078 on 1.0.x 
    Issue #3506379: Broken/Missing block in block layout
mandclu’s picture

mandclu commented
Status: Reviewed & tested by the community » Fixed

Thanks for the quick review! Merged in.

mandclu’s picture

mandclu commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.