Deprecated function: str_replace() [#3505215]

Problem/Motivation

I am getting this error in the log messages:

Deprecated function: str_replace(): Passing null to parameter #2 ($replace) of type array|string is deprecated in Drupal\ai_assistant_api\Service\AssistantMessageBuilder->buildMessage() (line 110 of /var/www/html/web/modules/contrib/ai/modules/ai_assistant_api/src/Service/AssistantMessageBuilder.php)

Solution:
This is a PHP 8.1+ deprecation warning to ensure the placeholders are safely replaced.
To fix this you can convert NULL to an empty string before calling str_replace().

Steps to reproduce

I am using Core 11.1.2 and AI module version 1.0.4.

Issue fork ai-3505215

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3505215-deprecated-function-strreplace changes, plain diff MR !460
Check out this branch for the first time

Check out existing branch, if you already have it locally
1.0.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 February 2025 at 17:40

torfj created an issue. See original summary.

Comment #2

7 February 2025 at 17:41

torfj opened merge request !460

Comment #3

torfj

Seattle, WA

commented 7 February 2025 at 17:42

I am a MR with the changes that will convert NULL to an empty string before calling str_replace().

Comment #4

mrdalesmith commented 10 February 2025 at 09:49

I'm not sure that's the way to go: if the $this->prePrompt() is empty you're just going to get the same error: it might be better if we check if the values exist before passing them to str_replace()?