This is an extremely minor issue of documentation. In the commenting for hook_views_data in core/modules/views/views.api.php, these lines are incorrect:
// Default label for relationship in the UI.
'label' => t('Example node'),
The correct key is title, like so:
// Default label for relationship in the UI.
'title' => t('Example node'),
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !11149
Comments
Comment #2
quietone commentedChanges are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies.
The current comment is in agreement with the definition of 'label' in \Drupal\views\Plugin\views\relationship\RelationshipPluginBase. Is this suggested change correct?
Comment #3
nicxvan commentedComment #6
alvar0hurtad0Hi.
I've created a MR for this.
Comment #7
stanzin commentedHey, I was looking for beginner-friendly issues for newcomers in the #first-contribution channel and noticed this issue is tagged as 'Novice.' It seems the tag was added later. Although the MR is already up and correct, if it’s not accepted, could we consider saving this for newcomers?
perhaps we could reconsider the 'Novice' tag to align with its intended purpose. @quietone, @nicxvan and @alvar0hurtad0 your thoughts on this. This would help new contributors find beginner-friendly issues more easily, as I’m finding it a bit challenging to identify basic issues for newcomers. Thanks!
Comment #8
nicxvan commentedYeah I don't know the policy, @alvar0hurtad0 has over a hundred credits so I don't think he is a novice any more.
I added the tag before the MR was created expressly so a beginner could work on this.
Comment #9
stanzin commentedGot it, thanks for clarifying ! I’ll look for other beginner-friendly issues. Marking this as resolved then ?
Comment #10
nicxvan commentedNo it hasn't been reviewed yet.
Comment #11
stanzin commentedgot it, thanks )
Comment #12
cmlaraSee #3473667: [policy, no patch] Decide policy related to use of novice tag regarding the (lack of) policy regarding Novice tagged issues.
Comment #13
smustgrave commentedAppears to be other instances in the api file that are using label but correct key may be title. That needs to be verified too.
Comment #14
alvar0hurtad0Hi,
my apologies if I overstep. I was just trying to contribute a bit. I've a super tight schedule in my personal live and most of the contribution time that my employer give to me is spend in events organization and mentoring. So I saw something I can do in just a few minutes and I decided to go for it.
Sorry again if it was inappropriate.
Comment #16
daniel_mm02 commentedHi, I've added a commit to try to fix it, I think it's correct, if not let me know and I'll take a look at it.
Comment #17
alvar0hurtad0Comment #18
smustgrave commentedBelieve this is correct.
Comment #19
nicxvan commentedComment #20
quietone commentedComment #22
quietone commentedThe intention of the 'Novice' tag can be found in the list of Issue tags -- special tags. It states,
What that means on each issue can, and should be different. For some issues, like this one the task is to create the 'correct MR', for other it could be that the 'review' is suitable for a novice. In fact, this one is suitable for a novice contributor to learn about the review process.
Comment #23
quietone commentedCommitted 5221f2e and pushed to 11.x. Thanks!