See discussion in #3493911: Add a CachedPlaceholderStrategy to optimize render cache hits and reduce layout shift from big pipe and #3493406: Add render caching for the navigation render array. Opening this issue for the actual conversion of the navigation render array to use a #lazy_builder from #pre_render, code is already in #3493911: Add a CachedPlaceholderStrategy to optimize render cache hits and reduce layout shift from big pipe.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | CleanShot 2025-02-05 at 22.19.41.gif | 536.1 KB | lauriii |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
catchLooks great. If we are OK with layout shift in HEAD then I think this could land independently of #3493911: Add a CachedPlaceholderStrategy to optimize render cache hits and reduce layout shift from big pipe, so moving straight to RTBC.
Comment #5
alexpottGiven we have the issue to fix the layout shift in progress already let's go ahead here.
Committed 5413e9f and pushed to 11.x. Thanks!
Comment #7
lauriiiI can't toggle the navigation anymore after this change 🤔
Comment #8
plopescThank you for reporting!
Filled #3504722: Navigation Expand/Collapse logic is not working properly in conjunction with Big Pipe to keep track of it.