Overview

Clicking "delete page" deletes the page.

Blocked on #3502820: List available pages in editor navigation

Proposed resolution

This is a full delete and not staged

User interface changes

Issue fork experience_builder-3503414

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Postponed » Active
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Note that this will require a delete() method in \Drupal\experience_builder\Controller\ApiContentControllers + a route.

attilatilman made their first commit to this issue’s fork.

attilatilman opened merge request !630

attilatilman’s picture

attilatilman commented
Status: Active » Needs review

wim leers credited jessebaker.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Looking good! A few TODOs that need doing, one genuine bug, and an (optional) request for a helper method.

attilatilman’s picture

attilatilman commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

The new e2e test is failing:

    cy:command ✔  findByLabelText	Page options for Empty Page
      cy:command ✔  click	
      cy:command ✔  contains	div.rt-BaseMenuItem, Delete page
      cy:command ✔  click	
      cy:command ✔  contains	button, Delete page
      cy:command ✔  click	
        cy:fetch ➟  GET http://localhost/web/session/token
                    Status: 200
        cy:fetch ➟  DELETE http://localhost/web/xb/api/content-delete/xb_page/2
                    Status: 204
      cy:command ✘  wait	@deletePage
        cy:fetch ➟  GET http://localhost/web/xb/api/content/xb_page
                    Status: 200
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Page
Issue tags: +openapi

Approved the BE pieces of this MR. 👍

Still needed:

  1. failing tests, see #10
  2. the (trivial) openapi.yml feedback has not yet been addressed

traviscarden changed the visibility of the branch 3503414-allow-cms-author to hidden.

traviscarden changed the visibility of the branch 3503414-allow-cms-author to active.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Reviewed & tested by the community

Approved by all codeowners

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, everyone.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: mglaman » Unassigned
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Some follow ups from this issue
- #3507334: Deleting/updating a config entity and deleting a content entity should clear its values from the auto-save store
- #3507335: Redirect to available page within XB after deleting the current page

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3507334: Deleting/updating a config entity and deleting a content entity should clear its values from the auto-save store, +#3507335: Redirect to available page within XB after deleting the current page

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.