Problem/Motivation

Drupal.Commenting.FunctionComment.TypeHintMissing was removed from Coder in #3205017: FunctionComment broken for complex string types about 2 years ago.

Steps to reproduce

Proposed resolution

Remove <exclude name="Drupal.Commenting.FunctionComment.TypeHintMissing"/> from phpcs.xml.dist

Remaining tasks

Create MR
Review
Commit

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3503268

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

koustav_mondal’s picture

koustav_mondal commented
Assigned: Unassigned » koustav_mondal

Working on it.

koustav_mondal opened merge request !11058

koustav_mondal’s picture

koustav_mondal commented
Assigned: koustav_mondal » Unassigned
Status: Active » Needs review

Made the changes. Please review it.

quietone’s picture

quietone commented
Issue tags: -Coding standards. Novice +Coding standards, +Novice

Fixing tag

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Marking as rtbc, the pull requests removes the rule mentioned in the IS.

nod_ made their first commit to this issue’s fork.

nod_ closed merge request !11058

  • nod_ committed 1202b000 on 11.x 
    Issue #3503268 by koustav_mondal, quietone: Remove Drupal.Commenting....
nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Fixed

Committed 1202b00 and pushed to 11.x. Thanks!

quietone credited acrosman.

quietone credited dave reid.

quietone credited Lars Toomre.

quietone credited naught101.

quietone credited penyaskito.

quietone credited rajeshwari10.

quietone credited robloach.

quietone credited sarhugo.

quietone credited undertext.

quietone’s picture

quietone commented
quietone’s picture

quietone commented

Closed #3107000: Fix Drupal.Commenting.FunctionComment.TypeHintMissing as a duplicate and moving credit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.