Overview

We override cores component plugin manager with additional methods.
In #3498889: ComponentSource plugin for code components we moved a lot of the requirements checking to it's own service.
We can possibly go further and move \Drupal\experience_builder\Plugin\ComponentPluginManager::createComponentMetadataFromPluginDefinition into a method on the source plugin

Proposed resolution

See if we can remove the additions to ComponentPluginManager further

User interface changes

None.

Issue fork experience_builder-3502988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Miscellaneous » Code
Issue tags: +API clean-up
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: [PP-1] Remove more component manager overrides » Remove more component manager overrides

longwave opened merge request !601

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review

Moved componentMeetsRequirements() to the source plugin, removed createComponentMetadataFromPluginDefinition() entirely as we have the plugin available anyway and can retrieve the metadata from it.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Novice
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

isholgueras made their first commit to this issue’s fork.

isholgueras’s picture

isholgueras commented
Status: Needs work » Needs review

Rerolled

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove more component manager overrides » Move more `ComponentPluginManager` methods to the SDC `ComponentSource`
Component: Code » Config management
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks, @isholgueras! 😄

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Config management » Component sources

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.