Problem/Motivation

Currently the display machine name in commerce_pvt_entity_extra_field_info() is commerce_pvt_field while the the render array element in commerce_pvt_commerce_product_view() is commerce_pvt.

This mismatch means the position of the field can't be set in the UI.

Steps to reproduce

  1. Install Commerce, Commerce PVT etc. and add a product with variations
  2. Install Field Layout (we're also using Field Group)
  3. In "Manage display" for the product, select a layout, (optionally add a field group) and position the Commerce PVT field in a column/region

The Commerce PVT field always appears outside the selected layout.

Proposed resolution

Set the display machine name and component name to the same as the render array element.

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

imclean created an issue. See original summary.

imclean’s picture

Status: Active » Needs review
eglaw’s picture

Good call !
Merged, released 2.0.0-beta8.

Please check the new release

eglaw’s picture

Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.