Problem/Motivation

Starting with Drupal 10.3.0, 'dialogClass' has been replaced with 'classes' in core dialog AJAX commands. As a result, the 'autologout-dialog' added with https://www.drupal.org/project/autologout/issues/1243938 no longer gets applied to the Autologout dialog.

Steps to reproduce

  • Trigger the Autologout dialog on Drupal 10.3.0+
  • Inspect the dialog element
  • The 'autologout-dialog' class will not be present on the element

Proposed resolution

Add the 'classes' option and keep 'dialogClass' to maintain backwards compatibility.

Issue fork autologout-3502534

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gombi created an issue. See original summary.

gombi’s picture

gombi commented
Assigned: gombi » Unassigned

gombi opened merge request !75

gombi’s picture

gombi commented
Title: dialogClass option no longer working on Drupal 10.3+ » dialogClass option no longer working on Drupal 10.3.0+
gombi’s picture

gombi commented
Status: Active » Needs review
admirlju’s picture

admirlju commented
Status: Needs review » Reviewed & tested by the community

It looks like this fixes the dialog issues for me. LGTM.

japerry made their first commit to this issue’s fork.

  • japerry committed 9cac0ca6 on 8.x-1.x authored by gombi 
    Issue #3502534 by gombi: dialogClass option no longer working on Drupal...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed
the_g_bomb’s picture

the_g_bomb commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Fixed » Patch (to be ported)

Should this have gone into the 2.x branch as well?

the_g_bomb opened merge request !85

  • japerry committed 9cac0ca6 on 2.x authored by gombi 
    Issue #3502534 by gombi: dialogClass option no longer working on Drupal...
the_g_bomb’s picture

the_g_bomb commented
Status: Patch (to be ported) » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.