Problem/Motivation

Drupal core currently lacks a reusable "Feed Icon" component,. This results in inconsistent styling and redundant implementations across the site. The creation of a standardized "Feed Icon" SDC will ensure design consistency, reusable code, and improved maintainability. This component will also enhance accessibility and will align with the design system for a cohesive user experience.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3502353

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ignaciofarre created an issue. See original summary.

ignaciofarre’s picture

ignaciofarre commented
Title: Create a headline SDC component for Feed Icon » Migrate Feed Icon SDC component

ignaciofarre opened merge request !11009

ignaciofarre closed merge request !11009

ignaciofarre opened merge request !11010

ignaciofarre closed merge request !11010

ignaciofarre’s picture

ignaciofarre commented

MR created by error https://git.drupalcode.org/project/drupal/-/merge_requests/11011

ignaciofarre reopened merge request !11010

ignaciofarre’s picture

ignaciofarre commented
Status: Active » Needs review
Issue tags: +olivero, +Theme Component Library
quietone’s picture

quietone commented
Version: 11.1.x-dev » 11.x-dev
Assigned: ignaciofarre » Unassigned
Issue tags: -olivero

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies.

Un-assigning per Assigning ownership of a Drupal core issue.

ironnuts’s picture

ironnuts commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs issue summary update

I have updated the issue summary.

More work is required.

ironnuts’s picture

ironnuts commented

There is currently one failure in the pipeline. It is during CSS linting.

Line 275:

[22:14:22] 'themes/olivero/components/atoms/feed_icon/feed_icon.pcss.css' does not match its CSS file. Recompile the CSS with: yarn run build:css

Not sure how to fix that. Any ideas?

ignaciofarre’s picture

ignaciofarre commented
Status: Needs work » Needs review
ironnuts’s picture

ironnuts commented

@ignaciofarre It's not ready for review since there is still a failing stage in the pipeline. See #12. Have you tried fixing it?

ironnuts’s picture

ironnuts commented
Status: Needs review » Needs work
ignaciofarre’s picture

ignaciofarre commented
Status: Needs work » Needs review

I'm so sorry @oily.

I fixed the compilation error with the PCSS file. However, there is another error in the MR, and I’m not sure how to fix it or if I need to fix it myself.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: -Needs tests +Needs manual testing

Removing the tests tag as ideally nothing should appear to have changed. But will need manual testing.
Left some comments on MR, issue summary should be complete also.

ironnuts’s picture

ironnuts commented

@ignaciofarre #16 No need. Great work so far.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)

The icon was removed in #3571623: Remove deprecated code from the Node module

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.