Overview

In #3491978: Implement saving block settings forms we temporarily added a new form state for block forms
We didn't add code to clear the current form state if the block being edited changes

Steps to reproduce

Edit one block
Edit another block
See the form state is polluted with values from both which end up in the model for the later when changed

Proposed resolution

In the listener middleware like we already have for clearing the component form state also clear block form state.

User interface changes

CommentFileSizeAuthor
Screenshot from 2025-01-24 09-29-45.png74.24 KBlarowlan

Issue fork experience_builder-3501870

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !580

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » jessebaker
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
Related issues: +#3491978: Implement saving block settings forms

AHHHH! I thought I was going mad while testing #3491978: Implement saving block settings forms because I did run into this but failed to reach this logical conclusion!

jessebaker made their first commit to this issue’s fork.

  • jessebaker committed e4e6a5a8 on 0.x authored by larowlan 
    Issue #3501870 by larowlan, wim leers: Block form state not cleared when...
jessebaker’s picture

jessebaker commented
Assigned: jessebaker » Unassigned
Status: Reviewed & tested by the community » Fixed

Approved and merged! Good catch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.